tillrohrmann commented on a change in pull request #6729: [FLINK-10386]
[taskmanager] Remove legacy class TaskExecutionStateListener
URL: https://github.com/apache/flink/pull/6729#discussion_r222605330
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
##########
@@ -846,6 +817,23 @@ public void
testSetsUserCodeClassLoaderForTimerThreadFactory() throws Throwable
// Test Utilities
//
------------------------------------------------------------------------
+ private static void waitUntilExecutionState(Task task, ExecutionState
exceptedState, Deadline deadline) {
+ while (deadline.hasTimeLeft()) {
+ if (exceptedState == task.getExecutionState()) {
+ return;
+ }
+
+ try {
+
Thread.sleep(Math.min(deadline.timeLeft().toMillis(), 200));
Review comment:
Did you already addressed this comment @TisonKun? I agree with @Clarkkkkk
that we should try to never do busy loop waiting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
