diego-carvallo-tx commented on a change in pull request #6789:
[FLINK-10316][kinesis] bug was preventing FlinkKinesisProducer to connect to
Kinesalite
URL: https://github.com/apache/flink/pull/6789#discussion_r222859878
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
##########
@@ -266,10 +266,18 @@ public static void validateAwsConfiguration(Properties
config) {
}
}
- if (!(config.containsKey(AWSConfigConstants.AWS_REGION) ^
config.containsKey(ConsumerConfigConstants.AWS_ENDPOINT))) {
- // per validation in AwsClientBuilder
- throw new
IllegalArgumentException(String.format("Either AWS region ('%s') or AWS
endpoint ('%s') must be set in the config.",
- AWSConfigConstants.AWS_REGION,
AWSConfigConstants.AWS_REGION));
+ if (isProducer) {
Review comment:
Thanks for the suggestion, I just pushed the code with this change and also
updated the PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
