[ 
https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641607#comment-16641607
 ] 

ASF GitHub Bot commented on FLINK-10247:
----------------------------------------

Clarkkkkk commented on issue #6759: [FLINK-10247][Metrics] Run 
MetricQueryService in a dedicated actor system
URL: https://github.com/apache/flink/pull/6759#issuecomment-427780030
 
 
   Thanks for your review @tillrohrmann . I have replace the RPC service with 
actor system and get rid of the additional options. 
   Meanwhile, I have some thoughts that need to discuss with you . As the actor 
system is dedicated for the metric query service, should we start the actor 
system in the MetricRegistry instead of in the ClusterEntrypoint and 
TaskManagerRunner? And the actor system can be shutdown during the shutdown 
process of MetricRegistry.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Run MetricQueryService in separate thread pool
> ----------------------------------------------
>
>                 Key: FLINK-10247
>                 URL: https://issues.apache.org/jira/browse/FLINK-10247
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Metrics
>    Affects Versions: 1.5.3, 1.6.0, 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: Shimin Yang
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.7.0, 1.6.2, 1.5.5
>
>
> In order to make the {{MetricQueryService}} run independently of the main 
> Flink components, it should get its own dedicated thread pool assigned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to