tillrohrmann commented on issue #6759: [FLINK-10247][Metrics] Run 
MetricQueryService in a dedicated actor system
URL: https://github.com/apache/flink/pull/6759#issuecomment-427786350
 
 
   Thanks for updating this PR @Clarkkkkk. I'll give it a pass later today. 
   
   I think we should not instantiate the `ActorSystem` inside of the 
`MetricRegistry` and instead pass it in. That way we are flexible where the 
`QueryMetricServiceActor` is running. E.g. in other setups it might be 
acceptable to share an `ActorSystem` with another component.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to