[
https://issues.apache.org/jira/browse/FLINK-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641734#comment-16641734
]
ASF GitHub Bot commented on FLINK-10513:
----------------------------------------
tillrohrmann commented on issue #6804: [FLINK-10513] Replace
TaskManagerActions#notifyFinalState with #updateTaskExecutionState
URL: https://github.com/apache/flink/pull/6804#issuecomment-427808601
I would not inline it, because `notifyFinalState` gives a little bit more
context (namely that we've reached the final state) also implying that you
should not call it if you haven't reached a final state yet. But it is mainly a
matter of taste, I agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace TaskManagerActions#notifyFinalState with #updateTaskExecutionState
> --------------------------------------------------------------------------
>
> Key: FLINK-10513
> URL: https://issues.apache.org/jira/browse/FLINK-10513
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> We can simplify the {{TaskManagerActions}} interface by replacing calls to
> the {{notifyFinalState}} method by {{updateTaskExecutionState}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
