[
https://issues.apache.org/jira/browse/FLINK-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697222#comment-14697222
]
ASF GitHub Bot commented on FLINK-1962:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1004#issuecomment-131148744
Wow, looks like a good piece of work. Nicely with tests and everything.
Build also passes, style looks good.
+1 to merge this from my side. I'd like to wait for a day or two to get a
comment from one of the Gelly people (Vasia or Andra).
One thing, though: In the Batch and streaming APIs, we added a
"completeness check" to make sure that methods added to the Java APIs are also
present in the Scala APIs. Would that be a good thing to add here as well?
> Add Gelly Scala API
> -------------------
>
> Key: FLINK-1962
> URL: https://issues.apache.org/jira/browse/FLINK-1962
> Project: Flink
> Issue Type: Task
> Components: Gelly, Scala API
> Affects Versions: 0.9
> Reporter: Vasia Kalavri
> Assignee: PJ Van Aeken
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
