GJL commented on a change in pull request #6737: [FLINK-10399] Refactor
ParameterTool#fromArgs
URL: https://github.com/apache/flink/pull/6737#discussion_r223348499
##########
File path:
flink-java/src/test/java/org/apache/flink/api/java/utils/AbstractParameterToolTest.java
##########
@@ -52,30 +52,29 @@ protected void validate(ParameterTool parameter) {
} catch (Exception e) {
fail();
Review comment:
Since you are already cleaning up:
The test will fail if an exception is propagated. There is no need to to
catch it and fail explicitly. Also we are currently masking the root cause.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
