TisonKun commented on a change in pull request #6737: [FLINK-10399] Refactor
ParameterTool#fromArgs
URL: https://github.com/apache/flink/pull/6737#discussion_r223416786
##########
File path:
flink-java/src/test/java/org/apache/flink/api/java/utils/AbstractParameterToolTest.java
##########
@@ -52,30 +52,29 @@ protected void validate(ParameterTool parameter) {
} catch (Exception e) {
fail();
Review comment:
I refactor it as
```java
try {
byte[] b = InstantiationUtil.serializeObject(parameter);
final ParameterTool copy =
InstantiationUtil.deserializeObject(b, getClass().getClassLoader());
internalValidate(copy);
} catch (Exception e) {
e.printStackTrace();
Assert.fail(e.getMessage());
}
```
this keeps the root cause and save us from modify signature of methods
calling `AbstractParameterToolTest#validate`. If you prefer to propagate it, I
am not opposite to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
