zhijiangW commented on a change in pull request #6698: [FLINK-8581][network]
Move flushing remote subpartitions from OutputFlusher to netty
URL: https://github.com/apache/flink/pull/6698#discussion_r223552250
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -97,6 +107,18 @@ public void run() {
});
}
+ void registerPeriodicFlush(NetworkSequenceViewReader reader, long
flushTimeout) {
+ if (flushTimeout == 0) {
Review comment:
This condition check can be done earlier in `ResultPartition` or
`ResultSubpartition` stack?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
