[ 
https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642999#comment-16642999
 ] 

ASF GitHub Bot commented on FLINK-8302:
---------------------------------------

pnowojski commented on a change in pull request #6445: [FLINK-8302] [table] Add 
SHIFT_LEFT and SHIFT_RIGHT
URL: https://github.com/apache/flink/pull/6445#discussion_r223611234
 
 

 ##########
 File path: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarOperatorsTest.scala
 ##########
 @@ -74,6 +74,103 @@ class ScalarOperatorsTest extends ScalarOperatorsTestBase {
       "true")
   }
 
+  @Test
+  def testShiftLeft(): Unit = {
+    testAllApis(
+      3.shiftLeft(3),
 
 Review comment:
   What happens with negative shift arguments? `3.shiftLeft(-3)`? Ditto for 
`shiftRight`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support shift_left and shift_right in TableAPI
> ----------------------------------------------
>
>                 Key: FLINK-8302
>                 URL: https://issues.apache.org/jira/browse/FLINK-8302
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: DuBin
>            Priority: Major
>              Labels: features, pull-request-available
>             Fix For: 1.7.0
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Add shift_left and shift_right support in TableAPI, shift_left(input, n) act 
> as input << n, shift_right(input, n) act as input >> n.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to