zentol commented on a change in pull request #6702: [FLINK-10135] The
JobManager does not report the cluster-level metrics
URL: https://github.com/apache/flink/pull/6702#discussion_r223627773
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -909,6 +913,11 @@ private void clearDispatcherState() {
terminateJobManagerRunners();
}
+ private void registerJobSpecificMetrics(MetricGroup
jobManagerMetricGroup) {
Review comment:
the name is slightly misleading; I would expect this to register metrics
about a particular job(s). It would be fine to call this
`registerDispatcherMetrics`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
