pnowojski commented on a change in pull request #6809: [FLINK-10491][network]
Pass BufferPoolOwner in the constructor of LocalBufferPool
URL: https://github.com/apache/flink/pull/6809#discussion_r223661469
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
##########
@@ -349,11 +346,13 @@ public void setNumBuffers(int numBuffers) throws
IOException {
returnExcessMemorySegments();
- // If there is a registered owner and we have still
requested more buffers than our
- // size, trigger a recycle via the owner.
- if (owner != null && numberOfRequestedMemorySegments >
currentPoolSize) {
-
owner.releaseMemory(numberOfRequestedMemorySegments - currentPoolSize);
- }
+ numReleased = numberOfRequestedMemorySegments -
currentPoolSize;
+ }
+
+ // If there is a registered owner and we have still requested
more buffers than our
+ // size, trigger a recycle via the owner.
+ if (owner != null && numReleased > 0) {
+ owner.releaseMemory(numReleased);
Review comment:
Are you sure that doing this outside of the `synchronized` block will not
cause some race conditions? After this change from the perspective of different
threads interacting with this class, memory will not be release during
`setNumBuffers` but at some random point time in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
