[ 
https://issues.apache.org/jira/browse/FLINK-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643978#comment-16643978
 ] 

ASF GitHub Bot commented on FLINK-10423:
----------------------------------------

sjwiesman opened a new pull request #6814: [FLINK-10423][rocksdb][metrics] 
rocksdb native metrics monitor
URL: https://github.com/apache/flink/pull/6814
 
 
   ## What is the purpose of the change
   Optionally expose RocksDB native metrics to Flink metrics reporter. All 
metrics are optionally configured using `OptionsFactory` report at the column 
family level and return unsigned long values. Metrics reporting is disabled by 
default to prevent unexpected performance regressions. 
   
   ## Brief change log
     - Implement RocksDBNativeMetricMonitor to periodically pull native metrics 
from RocksDB
     - Make metrics configurable through OptionsFactory 
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     -  Added RocksDBNativeMetricTest
     - Manually verified with a test cluster
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? javadoc
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Forward RocksDB memory metrics to Flink metrics reporter 
> ---------------------------------------------------------
>
>                 Key: FLINK-10423
>                 URL: https://issues.apache.org/jira/browse/FLINK-10423
>             Project: Flink
>          Issue Type: New Feature
>          Components: Metrics, State Backends, Checkpointing
>            Reporter: Seth Wiesman
>            Assignee: Seth Wiesman
>            Priority: Major
>              Labels: pull-request-available
>
> RocksDB contains a number of metrics at the column family level about current 
> memory usage, open memtables,  etc that would be useful to users wishing 
> greater insight what rocksdb is doing. This work is inspired heavily by the 
> comments on this rocksdb issue thread 
> (https://github.com/facebook/rocksdb/issues/3216#issuecomment-348779233)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to