[ 
https://issues.apache.org/jira/browse/FLINK-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698160#comment-14698160
 ] 

ASF GitHub Bot commented on FLINK-2526:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1020#discussion_r37134398
  
    --- Diff: 
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/OneInputStreamTask.java
 ---
    @@ -100,9 +100,27 @@ public void invoke() throws Exception {
                        this.isRunning = false;
                        // Cleanup
                        inputProcessor.clearBuffers();
    -                   inputProcessor.cleanup();
    -                   outputHandler.flushOutputs();
    -                   clearBuffers();
    +
    +                   try {
    +                           inputProcessor.cleanup();
    +                   }
    +                   catch (Exception e) {
    +                           LOG.warn("Clean up input processor failed.");
    --- End diff --
    
    the exception message shouldn't be discarded.


> Add catch{} for task when it stop running 
> ------------------------------------------
>
>                 Key: FLINK-2526
>                 URL: https://issues.apache.org/jira/browse/FLINK-2526
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 0.8.1
>            Reporter: fangfengbin
>            Assignee: fangfengbin
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to