[
https://issues.apache.org/jira/browse/FLINK-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644783#comment-16644783
]
ASF GitHub Bot commented on FLINK-9932:
---------------------------------------
shuai-xu commented on issue #6780: [FLINK-9932] [runtime] fix slot leak when
task executor offer slot to job master timeout
URL: https://github.com/apache/flink/pull/6780#issuecomment-428519342
@tillrohrmann, thank for the reviewing. So your suggestion is:
1. Move the marking active back to the callback.
2. Mark the slot active if in allocated when submit task.
3. If already active when call back, check the allocation and ignore if the
same.
It seems good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> If task executor offer slot to job master timeout the first time, the slot
> will leak
> ------------------------------------------------------------------------------------
>
> Key: FLINK-9932
> URL: https://issues.apache.org/jira/browse/FLINK-9932
> Project: Flink
> Issue Type: Bug
> Components: Cluster Management
> Affects Versions: 1.5.0
> Reporter: shuai.xu
> Assignee: shuai.xu
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> When task executor offer slot to job master, it will first mark the slot as
> active.
> If the offer slot call timeout, the task executor will try to call
> offerSlotsToJobManager again,
> but it will only offer the slot in ALLOCATED state. As the slot has already
> be mark ACTIVE, it will never be offered and this will cause slot leak.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
