sunjincheng121 commented on a change in pull request #6805:
[FLINK-10156][table] Deprecate Table.writeToSink()
URL: https://github.com/apache/flink/pull/6805#discussion_r224283829
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/TableSinkITCase.scala
##########
@@ -177,10 +195,16 @@ class TableSinkITCase extends AbstractTestBase {
.assignAscendingTimestamps(_._1.toLong)
.toTable(tEnv, 'id, 'num, 'text)
+ tEnv.registerTableSink(
+ "retractSink",
+ new TestRetractSink().configure(
+ Array[String]("len", "icnt", "nsum"),
+ Array[TypeInformation[_]](Types.INT, Types.LONG, Types.LONG)))
+
t.select('id, 'num, 'text.charLength() as 'len)
.groupBy('len)
- .select('len, 'id.count, 'num.sum)
- .writeToSink(new TestRetractSink)
+ .select('len, 'id.count as 'icnt, 'num.sum as 'nsum)
Review comment:
In order to show that the column name of the source table can be
inconsistent with the column name of the sink table, I recommend removing the
alias. What do you think？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
