twalthr commented on a change in pull request #6815: [FLINK-7062][cep][table]
Added basic support for MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/6815#discussion_r224362564
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala
##########
@@ -245,6 +246,40 @@ class RelTimeIndicatorConverter(rexBuilder: RexBuilder)
extends RelShuttle {
rowType.getFieldList.exists(field => isRowtimeIndicatorType(field.getType))
}
+ private def convertMatch(`match`: Match): LogicalMatch = {
Review comment:
Inline method into visit? Rename the match variable to make the code more
readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services