pnowojski opened a new pull request #6833: [FLINK-10537][network] Fix network small performance degradation after merging [FLINK-9913] URL: https://github.com/apache/flink/pull/6833 This PR tries to address small performance regression first [spotted here](https://github.com/apache/flink/pull/6417#pullrequestreview-154263375) and [visible here](http://codespeed.dak8s.net:8000/timeline/#/?exe=1&ben=networkThroughput.1,100ms&env=2&revs=200&equid=off&quarts=on&extr=on). Checks removed by this commit were performed once per every record, while before [FLINK-9913] those checks were executed only once per "continue writing with new buffer". Apparently those checks have some overhead once per record while are helping to avoid the need to commit the data very rarely. This change is covered by existing tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (**yes** / no / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
