[
https://issues.apache.org/jira/browse/FLINK-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648049#comment-16648049
]
ASF GitHub Bot commented on FLINK-10156:
----------------------------------------
fhueske commented on a change in pull request #6805: [FLINK-10156][table]
Deprecate Table.writeToSink()
URL: https://github.com/apache/flink/pull/6805#discussion_r224831240
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
##########
@@ -944,7 +956,12 @@ class Table(
* @param tableName Name of the registered [[TableSink]] to which the
[[Table]] is written.
*/
def insertInto(tableName: String): Unit = {
- tableEnv.insertInto(this, tableName, this.tableEnv.queryConfig)
+ this.logicalPlan match {
+ case _: LogicalTableFunctionCall =>
+ throw new ValidationException("TableFunction can only be used in join
and leftOuterJoin.")
+ case _ =>
+ tableEnv.insertInto(this, tableName, this.tableEnv.queryConfig)
Review comment:
The check is basically replacing the null check but provides more context.
What would we do if `tableEnv` is `null`? Do nothing? Throw an exception?
What would be the error message? By checking for the type of the root node of
the logical plan we know why the call would not succeed and can give an
appropriate error message.
We could of course also pass `null` as configuration and check for it to be
null in `insertInto(String, QueryConfig)` but I'd consider that as an invalid
use of the interface that should also result in an exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Drop the Table.writeToSink() method
> -----------------------------------
>
> Key: FLINK-10156
> URL: https://issues.apache.org/jira/browse/FLINK-10156
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
> Priority: Major
> Labels: pull-request-available
>
> I am proposing to drop the {{Table.writeToSink()}} method.
>
> *What is the method doing?*
> The {{Table.writeToSink(TableSink)}} method emits a {{Table}} via a
> {{TableSink}}, for example to a Kafka topic, a file, or a database.
>
> *Why should it be removed?*
> The {{writeToSink()}} method was introduced before the Table API supported
> the {{Table.insertInto(String)}} method. The {{insertInto()}} method writes a
> table into a table that was previously registered with a {{TableSink}} in the
> catalog. It is the inverse method to the {{scan()}} method and the equivalent
> to an {{INSERT INTO ... SELECT}} SQL query.
>
> I think we should remove {{writeToSink()}} for the following reasons:
> 1. It offers the same functionality as {{insertInto()}}. Removing it would
> reduce duplicated API.
> 2. {{writeToSink()}} requires a {{TableSink}} instance. I think TableSinks
> (and TableSources) should only be registered with the {{TableEnvironment}}
> and not be exposed to the "query part" of the Table API / SQL.
> 3. Registering tables in a catalog and using them for input and output is
> more aligned with SQL.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
