xccui commented on a change in pull request #6736: [FLINK-10398][table] Add
Tanh math function supported in Table API and SQL
URL: https://github.com/apache/flink/pull/6736#discussion_r224961146
##########
File path: docs/dev/table/functions.md
##########
@@ -1219,6 +1219,18 @@ TAN(numeric)
</td>
</tr>
+ <tr>
+ <td>
+ {% highlight text %}
+TANH(numeric)
+{% endhighlight %}
+ </td>
+ <td>
+ <p>Returns the hyperbolic tangent of <i>NUMERIC</i>.</p>
+ <p>Return value type is <i>DOUBLE</i>.</p>
Review comment:
Hi @yanghua, sorry for the inconvenience caused. First of all, I must admit
that the case problem was carelessly omitted by me in your last PR, even though
it had been pointed out. I'll fix it later.
About the documentation, yes, different contributors got different options
on the standard style. That is why the documentation looked a mess in the past
(the distributed contributions should not be an excuse) and it took me a lot of
time unifying the format. IMO, the document style is even more important than
the code style since it directly reflects the quality of a project, at least
for beginners. Hopefully, you could understand.
All the PRs I've reviewed recently are about built-in functions and their's
actually no big problem. However, even little changes can contain "bugs", which
should be taken carefully. So, I wonder if you could be patient with that.
Best, Xingcan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
