[
https://issues.apache.org/jira/browse/FLINK-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698583#comment-14698583
]
ASF GitHub Bot commented on FLINK-2531:
---------------------------------------
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1023#issuecomment-131503780
-1 for merging. I'm not an expert on flink-runtime, so I'm not sure but we
cannot merge this PR.
Because `acknowledgeTask` method change status of
`notYetAcknowledgedTasks`, We cannot combine the two if statements.
`isFullyAcknowledged` method must be called after calling `acknowledgeTask`
method.
> combining the "if" branch to improve the performance
> ----------------------------------------------------
>
> Key: FLINK-2531
> URL: https://issues.apache.org/jira/browse/FLINK-2531
> Project: Flink
> Issue Type: Bug
> Reporter: zhangrucong
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
