[ 
https://issues.apache.org/jira/browse/FLINK-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649816#comment-16649816
 ] 

ASF GitHub Bot commented on FLINK-10537:
----------------------------------------

zhijiangW commented on issue #6833: [FLINK-10537][network] Fix network small 
performance degradation after merging [FLINK-9913]
URL: https://github.com/apache/flink/pull/6833#issuecomment-429729793
 
 
   @pnowojski , thanks for finding this potential issue which would bring 
regression in some cases.
   
   I agree with your point that we actually brought more condition checks for 
every record in my last JIRA, and this can be indeed improved to keep the 
previous behavior. For the implementation I just have another concern inside 
the comments. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Network throughput performance regression after broadcast changes
> -----------------------------------------------------------------
>
>                 Key: FLINK-10537
>                 URL: https://issues.apache.org/jira/browse/FLINK-10537
>             Project: Flink
>          Issue Type: Bug
>          Components: Network
>    Affects Versions: 1.7.0
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>            Priority: Major
>              Labels: pull-request-available
>
> There is a slight network throughput regression introduced in: 
> https://issues.apache.org/jira/browse/FLINK-9913
> It is visible in the following benchmark:
> [http://codespeed.dak8s.net:8000/timeline/#/?exe=1&ben=networkThroughput.1,100ms&env=2&revs=200&equid=off&quarts=on&extr=on]
> (drop in the chart that happened since 21st September.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to