yanghua commented on issue #6816: [FLINK-10527] Cleanup constant isNewMode in 
YarnTestBase
URL: https://github.com/apache/flink/pull/6816#issuecomment-429769018
 
 
   > Hi @yanghua , I see your last commit and think it is still use the legacy 
mode. (Since you start an actor system and use `ActorGateway` instead of using 
FLIP-6 components.)
   
   @TisonKun  From my last comment, I am currently focusing on the failure of 
YARNSessionCapacitySchedulerITCase#testTaskManagerFailure.
   
   > To minimize this pull request as its title "Cleanup constant isNewMode in 
YarnTestBase", I propose to retain the clean up in `YARNSessionFIFOITCase`, 
simply remove `isNewMode` and add `@Ignore` to `YARNHighAvailabilityITCase`, 
`YARNSessionCapacitySchedulerITCase#testClientStartup` and 
`YARNSessionCapacitySchedulerITCase#testTaskManagerFailure`. Meanwhile, raising 
a JIRA about port those tests. What do you think?
   
   Agree your opinion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to