[
https://issues.apache.org/jira/browse/FLINK-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698603#comment-14698603
]
ASF GitHub Bot commented on FLINK-2530:
---------------------------------------
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1024#issuecomment-131512254
i don't think these statements are equivalent.
Assume that this.state == null and that.state != null.
In the original version we evaluate that.state == null, which is False, so
the overall result is False.
In your version we would evaluate (this.state == null ||
this.state.equals(that.state)), which is True, making the overall result true.
Unless i made a mistake, -1.
> optimize equal() of AcknowledgeCheckpoint
> -----------------------------------------
>
> Key: FLINK-2530
> URL: https://issues.apache.org/jira/browse/FLINK-2530
> Project: Flink
> Issue Type: Bug
> Components: Distributed Runtime
> Affects Versions: 0.8.1
> Reporter: fangfengbin
> Assignee: fangfengbin
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
