[ 
https://issues.apache.org/jira/browse/FLINK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650393#comment-16650393
 ] 

Fabian Hueske commented on FLINK-8578:
--------------------------------------

* Re Upsert Order: I'm not sure that I correctly understood what you said. Are 
you proposing to support non-timestamp fields as upsert fields? I think that 
could be interesting, but probably not required for a first version. 
Time-attributes (proctime and rowtime) should cover most cases.

* Re Time Attribute Handling: Yes, I think so, too. Should we also convert 
rowtime attributes into regular TIMESTAMP attributes, i.e., remove the 
time-attribute property. I think this would be OK, since there are no 
time-based operators that can handle updates or retractions.

> Implement rowtime DataStream to Table upsert conversion.
> --------------------------------------------------------
>
>                 Key: FLINK-8578
>                 URL: https://issues.apache.org/jira/browse/FLINK-8578
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Hequn Cheng
>            Assignee: Hequn Cheng
>            Priority: Major
>
> Flink-8577 implements upsert from stream under proctime. This task is going 
> to solve the order problem introduce by proctime. As proposed by Fabian in 
> FLINK-8545, it would be good to be able to declare a time attribute that 
> decides whether an upsert is performed or not.
> {code:java}
> Table table = tEnv.upsertFromStream(input, 'a, 'b.rowtime.upsertOrder, 'c.key)
> {code}
> This is a good way to solve the order problem using rowtime. And an idea 
> comes to my mind that we can even remove the `.upsertOrder`, because the 
> rowtime attribute can only be defined once in a table schema. Removing 
> `.upsertOrder` also makes it easier to design api for TableSource and sql, 
> i.e, we don't need to add another new feature for the api.
> Any suggestions are welcomed!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to