zhijiangW commented on a change in pull request #6833: [FLINK-10537][network]
Fix network small performance degradation after merging [FLINK-9913]
URL: https://github.com/apache/flink/pull/6833#discussion_r225475687
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java
##########
@@ -127,6 +116,7 @@ public void reset() {
@Override
public void prune() {
+ serializationBuffer.clear();
Review comment:
Although I can not understand why it would affect the performance in theory,
I agree with your point from the consistency of view to keep this logic.
Maybe it seems better set this position to 0 inside the
`serializationBuffer.pruneBuffer`. It's up to you for the decision. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
