StefanRRichter commented on issue #6856: [FLINK-10565] [tests] Refactor SchedulerTestBase URL: https://github.com/apache/flink/pull/6856#issuecomment-430269266 Overall, the changes look good. Why exactly did you extract the inner classes for this PR? I could not find any additional uses and it only makes the review slightly harder. If we find a use case where extraction makes sense at some point, we can extract them then. So I would suggest to revert the extraction for now and then I would merge the PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
