[
https://issues.apache.org/jira/browse/FLINK-10565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651852#comment-16651852
]
ASF GitHub Bot commented on FLINK-10565:
----------------------------------------
TisonKun commented on issue #6856: [FLINK-10565] [tests] Refactor
SchedulerTestBase
URL: https://github.com/apache/flink/pull/6856#issuecomment-430271134
@StefanRRichter I do the extract because a `TestingSlotPoolSlotProvider` can
be used to replace `Scheduler` used in other tests. At those places what is
needed is a `SlotProvider`.
However, you are right and I should have not mix them together. I think I am
a bit delirious that time. Would revert it soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor SchedulerTestBase
> --------------------------
>
> Key: FLINK-10565
> URL: https://issues.apache.org/jira/browse/FLINK-10565
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 1.7.0
> Reporter: TisonKun
> Assignee: TisonKun
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Basically, current {{SchedulerTestBase}} covers {{Scheduler}} tests, which is
> a schedule mechanism of legacy mode. We can remove it from
> {{SchedulerTestBase}}. Besides, inner {{SchedulerTestBase}} there are two
> useful testing class {{TestingSlotPool}} and {{TestingSlotPoolSlotProvider}}.
> Extract them for further usage.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
