fhueske commented on a change in pull request #6823: [FLINK-10134] UTF-16
support for TextInputFormat bug refixed
URL: https://github.com/apache/flink/pull/6823#discussion_r225539582
##########
File path:
flink-java/src/main/java/org/apache/flink/api/java/io/TextInputFormat.java
##########
@@ -68,6 +68,7 @@ public void setCharsetName(String charsetName) {
}
Review comment:
I would remove the `charsetName` field from `TextInputFormat` and add a
`getCharsetName()` method to `DelimitedInputFormat`.
Remove all logic from `setCharsetName()` except passing the `charsetName` on
to `DelimitedInputFormat.setCharset()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
