fhueske commented on a change in pull request #6823: [FLINK-10134] UTF-16
support for TextInputFormat bug refixed
URL: https://github.com/apache/flink/pull/6823#discussion_r225548099
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
##########
@@ -161,15 +178,17 @@ protected static void loadConfigParameters(Configuration
parameters) {
// The delimiter may be set with a byte-sequence or a String. In the
latter
// case the byte representation is updated consistent with current
charset.
private byte[] delimiter = new byte[] {'\n'};
+ protected int delimiterNewLinePos = 0;
Review comment:
These variables are only used in `TextInputFormat`. I would initialize and
move them there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
