[GitHub] zentol closed pull request #5686: [FLINK-8917] [Job-Submission] FlinkMiniCluster default createHighAvailabilityServices is not same as ClusterClient

[GitBox]

zentol closed pull request #5686: [FLINK-8917] [Job-Submission] 
FlinkMiniCluster default createHighAvailabilityServices is not same as 
ClusterClient
URL: https://github.com/apache/flink/pull/5686
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
 
b/flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
index 5554061997f..383792f380d 100644
--- 
a/flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
+++ 
b/flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
@@ -127,9 +127,9 @@ abstract class FlinkMiniCluster(
   def this(configuration: Configuration, useSingleActorSystem: Boolean) {
     this(
       configuration,
-      HighAvailabilityServicesUtils.createAvailableOrEmbeddedServices(
-        configuration,
-        ExecutionContext.global),
+      
HighAvailabilityServicesUtils.createHighAvailabilityServices(configuration,
+        org.apache.flink.runtime.concurrent.Executors.directExecutor,
+        
HighAvailabilityServicesUtils.AddressResolution.TRY_ADDRESS_RESOLUTION),
       useSingleActorSystem)
   }
 
diff --git 
a/flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/LocalFlinkMiniCluster.scala
 
b/flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/LocalFlinkMiniCluster.scala
index 8ef2e364293..71c7d1b5b4f 100644
--- 
a/flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/LocalFlinkMiniCluster.scala
+++ 
b/flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/LocalFlinkMiniCluster.scala
@@ -76,9 +76,10 @@ class LocalFlinkMiniCluster(
   def this(userConfiguration: Configuration, useSingleActorSystem: Boolean) = {
     this(
       userConfiguration,
-       HighAvailabilityServicesUtils.createAvailableOrEmbeddedServices(
+      HighAvailabilityServicesUtils.createHighAvailabilityServices(
          userConfiguration,
-         ExecutionContext.global),
+          org.apache.flink.runtime.concurrent.Executors.directExecutor,
+            
HighAvailabilityServicesUtils.AddressResolution.NO_ADDRESS_RESOLUTION),
       useSingleActorSystem)
   }
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services