[
https://issues.apache.org/jira/browse/FLINK-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653463#comment-16653463
]
ASF GitHub Bot commented on FLINK-10580:
----------------------------------------
tillrohrmann opened a new pull request #6867: [FLINK-10580] Harden
BootstrapTool#startActorSystem
URL: https://github.com/apache/flink/pull/6867
## What is the purpose of the change
Instead of opening a socket to check whether a given port is free we simply
start an
ActorSystem with it an check whether it can bind to this port. This also
solves the problem
that a 0 port get resolved to a specific port which might get taken between
closing the
test socket and starting the ActorSystem.
## Verifying this change
- Added `BootstrapToolsTest#testConcurrentActorSystemCreation` which failed
without this change (non-deterministically)
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> EventTimeWindowCheckpointingITCase fails on travis
> --------------------------------------------------
>
> Key: FLINK-10580
> URL: https://issues.apache.org/jira/browse/FLINK-10580
> Project: Flink
> Issue Type: Bug
> Components: Metrics, State Backends, Checkpointing, Streaming, Tests
> Affects Versions: 1.7.0
> Reporter: Chesnay Schepler
> Assignee: Till Rohrmann
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> https://travis-ci.org/apache/flink/jobs/442580164
> {code:java}
> Tests run: 42, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 385.268 sec
> <<< FAILURE! - in
> org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase
> testTumblingTimeWindowWithKVStateMinMaxParallelism[statebackend type
> =MEM_ASYNC](org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase)
> Time elapsed: 0.093 sec <<< ERROR!
> java.net.BindException: Could not start actor system on any port in port
> range 0
> at
> org.apache.flink.runtime.clusterframework.BootstrapTools.startActorSystem(BootstrapTools.java:193)
> at
> org.apache.flink.runtime.metrics.util.MetricUtils.startMetricsActorSystem(MetricUtils.java:126)
> at
> org.apache.flink.runtime.minicluster.MiniCluster.start(MiniCluster.java:260)
> at
> org.apache.flink.test.util.MiniClusterResource.startMiniCluster(MiniClusterResource.java:168)
> at
> org.apache.flink.test.util.MiniClusterResource.before(MiniClusterResource.java:96)
> at
> org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase.setupTestCluster(EventTimeWindowCheckpointingITCase.java:227)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
