twalthr commented on a change in pull request #6815: [FLINK-7062][cep][table] Added basic support for MATCH_RECOGNIZE URL: https://github.com/apache/flink/pull/6815#discussion_r225908626
########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamMatch.scala ########## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.plan.nodes.datastream + +import java.util + +import org.apache.calcite.plan.{RelOptCluster, RelTraitSet} +import org.apache.calcite.rel.RelFieldCollation.Direction +import org.apache.calcite.rel._ +import org.apache.calcite.rel.`type`.RelDataType +import org.apache.calcite.rex._ +import org.apache.calcite.sql.SqlKind +import org.apache.calcite.sql.SqlMatchRecognize.AfterOption +import org.apache.calcite.sql.fun.SqlStdOperatorTable._ +import org.apache.flink.api.common.typeinfo.TypeInformation +import org.apache.flink.api.common.typeutils.TypeComparator +import org.apache.flink.cep.nfa.aftermatch.AfterMatchSkipStrategy +import org.apache.flink.cep.nfa.compiler.NFACompiler +import org.apache.flink.cep.pattern.Pattern +import org.apache.flink.cep.pattern.Quantifier.QuantifierProperty +import org.apache.flink.cep.pattern.conditions.BooleanConditions +import org.apache.flink.cep.{CEP, EventComparator, PatternStream} +import org.apache.flink.streaming.api.datastream.DataStream +import org.apache.flink.table.api.{StreamQueryConfig, StreamTableEnvironment, TableConfig, TableException} +import org.apache.flink.table.calcite.FlinkTypeFactory +import org.apache.flink.table.plan.nodes.MatchRecognize +import org.apache.flink.table.plan.nodes.logical.FlinkLogicalMatch +import org.apache.flink.table.plan.schema.RowSchema +import org.apache.flink.table.plan.util.RexDefaultVisitor +import org.apache.flink.table.runtime.`match`._ +import org.apache.flink.table.runtime.aggregate.SortUtil +import org.apache.flink.table.runtime.types.{CRow, CRowTypeInfo} +import org.apache.flink.table.runtime.{RowKeySelector, RowtimeProcessFunction} +import org.apache.flink.types.Row +import org.apache.flink.util.MathUtils + +import scala.collection.JavaConverters._ + +/** + * Flink RelNode which matches along with LogicalMatch. + */ +class DataStreamMatch( + cluster: RelOptCluster, + traitSet: RelTraitSet, + input: RelNode, + logicalMatch: FlinkLogicalMatch, + schema: RowSchema, + inputSchema: RowSchema) + extends SingleRel(cluster, traitSet, input) + with MatchRecognize + with DataStreamRel { + + private[flink] def getLogicalMatch = logicalMatch + + override def deriveRowType(): RelDataType = schema.relDataType + + override def copy(traitSet: RelTraitSet, inputs: util.List[RelNode]): RelNode = { + new DataStreamMatch( + cluster, + traitSet, + inputs.get(0), + logicalMatch, + schema, + inputSchema) + } + + override def toString: String = { + matchToString(logicalMatch, inputSchema, getExpressionString) + } + + override def explainTerms(pw: RelWriter): RelWriter = { + explainMatch(super.explainTerms(pw), logicalMatch, inputSchema, getExpressionString) + } + + private def translateOrder( + tableEnv: StreamTableEnvironment, + crowInput: DataStream[CRow], + orderKeys: RelCollation) = { + + if (orderKeys.getFieldCollations.size() == 0) { + throw new TableException("You must specify either rowtime or proctime for order by.") Review comment: I would use `ValidationException` for exceptions here and in the following 2 cases where the user did something wrong. `TableException` is more for unexpected errors or unsupported things. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
