Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1029#discussion_r37166816 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/CompactingHashTable.java --- @@ -406,9 +403,7 @@ public void insertOrReplaceRecord(T record) throws IOException { return; } } - else { - numInSegment++; - } + numInSegment++; --- End diff -- this is not equivalent to the old implementation, since numInSegent is no longer incremented if "this.buildSideComparator.equalToReference(valueAtPosition)" is true, since we return.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---