[
https://issues.apache.org/jira/browse/FLINK-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699173#comment-14699173
]
ASF GitHub Bot commented on FLINK-2534:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1029#discussion_r37166816
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/CompactingHashTable.java
---
@@ -406,9 +403,7 @@ public void insertOrReplaceRecord(T record) throws
IOException {
return;
}
}
- else {
- numInSegment++;
- }
+ numInSegment++;
--- End diff --
this is not equivalent to the old implementation, since numInSegent is no
longer incremented if
"this.buildSideComparator.equalToReference(valueAtPosition)" is true, since we
return.
> Improve execution code in CompactingHashTable.java
> --------------------------------------------------
>
> Key: FLINK-2534
> URL: https://issues.apache.org/jira/browse/FLINK-2534
> Project: Flink
> Issue Type: Improvement
> Components: Local Runtime
> Affects Versions: 0.10
> Reporter: Huang Wei
> Fix For: 0.10
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I found some improved code in CompactingHashTable.java since this code will
> execute many times when flink runs.
> In my opinion, some codes in "for" and "while" can be optimized to reduce the
> times of execution and it is effective to increase the performance.
> For example, the code following:
> 'while(numBuckets % numPartitions != 0) {
> numBuckets++;
> }'
> can be optimized into a formula:
> numBuckets += numPartitions - (numBuckets % numPartitions);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
