tillrohrmann commented on a change in pull request #6872: [FLINK-10436] Add
ConfigOption#withFallbackKeys
URL: https://github.com/apache/flink/pull/6872#discussion_r226239715
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java
##########
@@ -701,12 +701,14 @@ public boolean contains(ConfigOption<?> configOption) {
if (this.confData.containsKey(configOption.key())) {
return true;
}
- else if (configOption.hasDeprecatedKeys()) {
- // try the deprecated keys
- for (String deprecatedKey :
configOption.deprecatedKeys()) {
- if
(this.confData.containsKey(deprecatedKey)) {
- LOG.warn("Config uses
deprecated configuration key '{}' instead of proper key '{}'",
- deprecatedKey,
configOption.key());
+ else if (configOption.hasFallbackKeys()) {
+ // try the fallback keys
+ for (FallbackKey fallbackKey :
configOption.fallbackKeys()) {
+ if
(this.confData.containsKey(fallbackKey.getKey())) {
+ if (fallbackKey.isDeprecated())
{
+ LOG.warn("Config uses
deprecated configuration key '{}' instead of proper key '{}'",
+
fallbackKey.getKey(), configOption.key());
Review comment:
The warning message could be factored out in one method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
