yanghua commented on a change in pull request #6816: [FLINK-10527] Cleanup
constant isNewMode in YarnTestBase
URL: https://github.com/apache/flink/pull/6816#discussion_r226258823
##########
File path:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.java
##########
@@ -189,9 +189,9 @@ public void perJobYarnClusterOffHeap() throws IOException {
/**
* Test TaskManager failure and also if the vcores are set correctly
(see issue FLINK-2213).
*/
+ @Ignore
@Test(timeout = 100000) // timeout after 100 seconds
public void testTaskManagerFailure() throws Exception {
- assumeTrue("The new mode does not start TMs upfront.",
!isNewMode);
Review comment:
@tillrohrmann You mean I should also keep the `assumeTrue` and remove
`@Ignore`? But in other PR, it caused test error :
```
testClientStartup(org.apache.flink.yarn.YARNSessionCapacitySchedulerITCase)
Time elapsed: 10.063 sec <<< ERROR!
org.junit.AssumptionViolatedException: The new mode does not start TMs
upfront.
at org.junit.Assume.assumeTrue(Assume.java:59)
at
org.apache.flink.yarn.YARNSessionCapacitySchedulerITCase.testClientStartup(YARNSessionCapacitySchedulerITCase.java:106)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
