[
https://issues.apache.org/jira/browse/FLINK-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655137#comment-16655137
]
ASF GitHub Bot commented on FLINK-10602:
----------------------------------------
tillrohrmann opened a new pull request #6877: [FLINK-10602] Use metric's
ActorSystem in MetricFetcher
URL: https://github.com/apache/flink/pull/6877
## What is the purpose of the change
Use the metric system's ActorSystem in the MetricFetcher. This makes the
fetching
of metrics run in a separate ActorSystem from the one used in the
RpcService. This
should decouple Flink from the metric system further and allows to
individually
configure both systems.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Run MetricFetcher in metrics ActorSystem
> ----------------------------------------
>
> Key: FLINK-10602
> URL: https://issues.apache.org/jira/browse/FLINK-10602
> Project: Flink
> Issue Type: Sub-task
> Components: Metrics
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> After letting the {{MetricQueryService}} run into a separate {{ActorSystem}},
> we should also let the {{MetricFetcher}} use the same {{ActorSystem}} to
> fetch the metrics. That way it will be possible to configure the metric
> {{ActorSystem}} different from the {{RpcService}} {{ActorSystem}} (e.g.
> different frame size).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
