[
https://issues.apache.org/jira/browse/FLINK-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655326#comment-16655326
]
ASF GitHub Bot commented on FLINK-10583:
----------------------------------------
pnowojski commented on a change in pull request #6871: [FLINK-10583][table] Add
base TwoInputStreamOperator with TTL operator.
URL: https://github.com/apache/flink/pull/6871#discussion_r226329300
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/AbstractTwoInputStreamOperatorWithTTL.scala
##########
@@ -51,11 +59,11 @@ abstract class AbstractTwoInputStreamOperatorWithTTL(
private val maxRetentionTime: Long = queryConfig.getMaxIdleStateRetentionTime
private val stateCleaningEnabled: Boolean = minRetentionTime > 1
- private val ACTIVE_CLEANUP_TIMESTAMP = "cleanup-timestamp"
+ private val CLEANUP_TIMESTAMP = "cleanup-timestamp"
private val TIMERS_STATE_NAME = "timers"
// the latest registered cleanup timer
- private var cleanupTimeState: ValueState[JLong] = _
+ private var cleanUpTimeState: ValueState[JLong] = _
Review comment:
rename variable to `latestRegisteredCleanUpTimer` and drop the comment. Name
`cleanUpTimeState` doesn't tell much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add support for state retention to the Processing Time versioned joins.
> -----------------------------------------------------------------------
>
> Key: FLINK-10583
> URL: https://issues.apache.org/jira/browse/FLINK-10583
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.7.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
