tillrohrmann commented on a change in pull request #6876: [FLINK-10251] Handle 
oversized response messages in AkkaRpcActor
URL: https://github.com/apache/flink/pull/6876#discussion_r226345993
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java
 ##########
 @@ -108,9 +111,11 @@
 
        private volatile boolean stopped;
 
-       public AkkaRpcService(final ActorSystem actorSystem, final Time 
timeout) {
+       public AkkaRpcService(final ActorSystem actorSystem, final 
Configuration configuration) {
 
 Review comment:
   Why did you pass the `Configuration` here? I think it would be better to 
revert this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to