zhijiangW commented on issue #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool URL: https://github.com/apache/flink/pull/6809#issuecomment-431236371 @pnowojski , thanks for reviews again! I have mainly two concerns of tests from comments. 1. How should we define the scope of this PR? I found another common issue that the new added tests may trigger some unreasonable history tests. If we solved all the related history tests in this PR, it may be not good for convergence for this PR. 2. How to evaluate the usages of mock, spy, etc in test? I have some thoughts in the comments. BTW, I learned some good ideas from your test reviews, then I think I would focus on polishing some existing history tests if have time. :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
