ifndef-SleePy commented on a change in pull request #6770: [FLINK-10002]
[Webfrontend] WebUI shows jm/tm logs more friendly.
URL: https://github.com/apache/flink/pull/6770#discussion_r226523853
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/files/LogFileHandlerSpecification.java
##########
@@ -25,12 +25,18 @@
* Rest handler specification for the log file of the main cluster component.
*/
public class LogFileHandlerSpecification implements RestHandlerSpecification {
-
- private static final LogFileHandlerSpecification INSTANCE = new
LogFileHandlerSpecification();
-
private static final String URL = "/jobmanager/log";
+ private static final String URL_WITH_RANGE = "/jobmanager/log/:range";
+ private static final String URL_WITH_FILENAME_AND_RANGE =
"/jobmanager/logs/:filename/:range";
- private LogFileHandlerSpecification() {}
+ private static final LogFileHandlerSpecification INSTANCE = new
LogFileHandlerSpecification(URL);
Review comment:
Singleton with multiple instances is not a good idea anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
