[
https://issues.apache.org/jira/browse/FLINK-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656516#comment-16656516
]
ASF GitHub Bot commented on FLINK-7062:
---------------------------------------
twalthr commented on a change in pull request #6815: [FLINK-7062][cep][table]
Added basic support for MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/6815#discussion_r226570156
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/MatchCodeGenerator.scala
##########
@@ -0,0 +1,383 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.codegen
+
+import java.lang.{Long => JLong}
+import java.util
+
+import org.apache.calcite.rex._
+import org.apache.calcite.sql.fun.SqlStdOperatorTable._
+import org.apache.commons.lang3.StringEscapeUtils
+import org.apache.flink.api.common.functions._
+import org.apache.flink.api.common.typeinfo.{SqlTimeTypeInfo, TypeInformation}
+import org.apache.flink.cep.pattern.conditions.IterativeCondition
+import org.apache.flink.cep.{PatternFlatSelectFunction, PatternSelectFunction}
+import org.apache.flink.table.api.{TableConfig, TableException}
+import org.apache.flink.table.codegen.CodeGenUtils.{boxedTypeTermForTypeInfo,
newName}
+import org.apache.flink.table.codegen.GeneratedExpression.NEVER_NULL
+import org.apache.flink.table.codegen.Indenter.toISC
+import org.apache.flink.table.plan.schema.RowSchema
+import org.apache.flink.util.Collector
+import org.apache.flink.util.MathUtils.checkedDownCast
+
+import scala.collection.JavaConverters._
+import scala.collection.mutable
+
+/**
+ * A code generator for generating CEP related functions.
+ *
+ * @param config configuration that determines runtime behavior
+ * @param input type information about the first input of the Function
+ * @param currentPattern if generating condition the name of pattern, which
the condition will
+ * be applied to
+ */
+class MatchCodeGenerator(
+ config: TableConfig,
+ input: TypeInformation[_ <: Any],
+ currentPattern: Option[String] = None)
+ extends CodeGenerator(config, false, input){
+
+ private case class GeneratedPatternList(resultTerm: String, code: String)
+
+ /**
+ * Used to assign unique names for list of events per pattern variable name
+ */
+ private val reusablePatternLists: mutable.HashMap[String,
GeneratedPatternList] = mutable
+ .HashMap[String, GeneratedPatternList]()
+
+ private def reusePatternLists(): String = {
+ reusablePatternLists.values.map(_.code).mkString("\n")
+ }
+
+ /**
+ * Generates a [[org.apache.flink.api.common.functions.Function]] that can
be passed to Java
+ * compiler.
+ *
+ * This is a separate method from
[[FunctionCodeGenerator.generateFunction()]] because as of
+ * now functions in CEP library do not support rich interfaces
+ *
+ * @param name Class name of the Function. Must not be unique but has to be
a valid Java class
+ * identifier.
+ * @param clazz Flink Function to be generated.
+ * @param bodyCode code contents of the SAM (Single Abstract Method).
Inputs, collector, or
+ * output record can be accessed via the given term methods.
+ * @param returnType expected return type
+ * @tparam F Flink Function to be generated.
+ * @tparam T Return type of the Flink Function.
+ * @return instance of GeneratedFunction
+ */
+ def generateMatchFunction[F <: Function, T <: Any](
+ name: String,
+ clazz: Class[F],
+ bodyCode: String,
+ returnType: TypeInformation[T])
+ : GeneratedFunction[F, T] = {
+ val funcName = newName(name)
+ val collectorTypeTerm = classOf[Collector[Any]].getCanonicalName
+ val (functionClass, signature, inputStatements, isInterface) =
+ if (clazz == classOf[IterativeCondition[_]]) {
+ val baseClass = classOf[IterativeCondition[_]]
+ val inputTypeTerm = boxedTypeTermForTypeInfo(input)
+ val contextType =
classOf[IterativeCondition.Context[_]].getCanonicalName
+
+ (baseClass,
+ s"boolean filter(Object _in1, $contextType $contextTerm)",
+ List(s"$inputTypeTerm $input1Term = ($inputTypeTerm) _in1;"),
+ false)
+ } else if (clazz == classOf[PatternSelectFunction[_, _]]) {
+ val baseClass = classOf[PatternSelectFunction[_, _]]
+ val inputTypeTerm =
+ s"java.util.Map<String,
java.util.List<${boxedTypeTermForTypeInfo(input)}>>"
+
+ (baseClass,
+ s"Object select($inputTypeTerm $input1Term)",
+ List(),
+ true)
+ } else if (clazz == classOf[PatternFlatSelectFunction[_, _]]) {
+ val baseClass = classOf[PatternFlatSelectFunction[_, _]]
+ val inputTypeTerm =
+ s"java.util.Map<String,
java.util.List<${boxedTypeTermForTypeInfo(input)}>>"
+
+ (baseClass,
+ s"void flatSelect($inputTypeTerm $input1Term, $collectorTypeTerm
$collectorTerm)",
+ List(),
+ true)
+ } else {
+ throw new CodeGenException("Unsupported Function.")
+ }
+
+ if (!reuseOpenCode().trim.isEmpty || !reuseCloseCode().trim.isEmpty) {
+ throw new TableException(
+ "Match recognize does not support UDFs, nor other functions that
require " +
+ "open/close methods yet.")
+ }
+
+ val extendsKeyword = if (isInterface) "implements" else "extends"
+ val funcCode = j"""
+ |public class $funcName $extendsKeyword
${functionClass.getCanonicalName} {
+ |
+ | ${reuseMemberCode()}
+ |
+ | public $funcName() throws Exception {
+ | ${reuseInitCode()}
+ | }
+ |
+ | @Override
+ | public $signature throws Exception {
+ | ${inputStatements.mkString("\n")}
+ | ${reusePatternLists()}
+ | ${reuseInputUnboxingCode()}
+ | ${reusePerRecordCode()}
+ | $bodyCode
+ | }
+ |}
+ """.stripMargin
+
+ GeneratedFunction(funcName, returnType, funcCode)
+ }
+
+ /**
+ * Extracts partition keys from any element of the match
+ *
+ * @param partitionKey partition key to be extracted
+ * @return generated code for the given key
+ */
+ private def generatePartitionKeyAccess(
+ partitionKey: RexInputRef)
+ : GeneratedExpression = {
+ val eventNameTerm = newName("event")
+ val eventTypeTerm = boxedTypeTermForTypeInfo(input)
+
+ val keyAccess = generateFieldAccess(input, eventNameTerm,
partitionKey.getIndex)
+
+ val keyCode = s"""
+ |$eventTypeTerm $eventNameTerm = null;
+ |for (java.util.Map.Entry entry : $input1Term.entrySet()) {
+ | java.util.List<$eventTypeTerm> value =
(java.util.List<$eventTypeTerm>) entry.getValue();
+ | if (value != null && value.size() > 0) {
+ | $eventNameTerm = ($eventTypeTerm) value.get(0);
+ | break;
+ | }
+ |}
+ |
+ |${keyAccess.code}
+ """.stripMargin
+
+ keyAccess.copy(code = keyCode)
+ }
+
+ def generateOneRowPerMatchExpression(
+ partitionKeys: util.List[RexNode],
+ measures: util.Map[String, RexNode],
+ returnType: RowSchema)
+ : GeneratedExpression = {
+ // For "ONE ROW PER MATCH", the output columns include:
+ // 1) the partition columns;
+ // 2) the columns defined in the measures clause.
+ val resultExprs =
+ partitionKeys.asScala.map { case inputRef: RexInputRef =>
+ generatePartitionKeyAccess(inputRef)
+ } ++ returnType.fieldNames.filter(measures.containsKey(_)).map {
fieldName =>
+ generateExpression(measures.get(fieldName))
+ }
+
+ generateResultExpression(
+ resultExprs,
+ returnType.typeInfo,
+ returnType.fieldNames)
+ }
+
+ private var first : Boolean = false
Review comment:
Put these fields to the beginning of the class. Also add comments to the
fields/methods to explain what they are good for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support the basic functionality of MATCH_RECOGNIZE
> --------------------------------------------------
>
> Key: FLINK-7062
> URL: https://issues.apache.org/jira/browse/FLINK-7062
> Project: Flink
> Issue Type: Sub-task
> Components: CEP, Table API & SQL
> Reporter: Dian Fu
> Assignee: Dian Fu
> Priority: Major
> Labels: pull-request-available
>
> In this JIRA, we will support the basic functionality of {{MATCH_RECOGNIZE}}
> in Flink SQL API which includes the support of syntax {{MEASURES}},
> {{PATTERN}} and {{DEFINE}}. This would allow users write basic cep use cases
> with SQL like the following example:
> {code}
> SELECT T.aid, T.bid, T.cid
> FROM MyTable
> MATCH_RECOGNIZE (
> MEASURES
> A.id AS aid,
> B.id AS bid,
> C.id AS cid
> PATTERN (A B C)
> DEFINE
> A AS A.name = 'a',
> B AS B.name = 'b',
> C AS C.name = 'c'
> ) AS T
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
