zentol commented on a change in pull request #6886: [BP-1.5][FLINK-10614] Let
test_batch_allround.sh rely on test-runner-common.sh for clean up
URL: https://github.com/apache/flink/pull/6886#discussion_r226653537
##########
File path: flink-end-to-end-tests/test-scripts/test_batch_allround.sh
##########
@@ -24,31 +24,13 @@
TEST_PROGRAM_JAR=${END_TO_END_DIR}/flink-dataset-allround-test/target/DataSetAll
echo "Run DataSet-Allround-Test Program"
# modify configuration to include spilling to disk
-cp $FLINK_DIR/conf/flink-conf.yaml $FLINK_DIR/conf/flink-conf.yaml.bak
echo "taskmanager.network.memory.min: 10485760" >>
$FLINK_DIR/conf/flink-conf.yaml
echo "taskmanager.network.memory.max: 10485760" >>
$FLINK_DIR/conf/flink-conf.yaml
backup_config
Review comment:
This doesn't look right, why are we creating a backup after modifying the
config? Also, we never seem to restore it anywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
