StefanRRichter commented on a change in pull request #6875: [FLINK-9808] [state 
backends] Migrate state when necessary in state backends
URL: https://github.com/apache/flink/pull/6875#discussion_r226679606
 
 

 ##########
 File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRocksDBState.java
 ##########
 @@ -154,6 +159,29 @@ public void setCurrentNamespace(N namespace) {
                return backend.db.get(columnFamily, 
tmpKeySerializationView.getCopyOfBuffer());
        }
 
+       public byte[] migrateSerializedValue(
 
 Review comment:
   I think this method does not belong here. This class is used to interact 
with the state during event processing, I suggest to keep that separated from 
migration concerns. If you are looking for a way to differentiate the logic for 
different states, you could also just use a factor that gives you different 
implementations of some `StateValueTransformer`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to