[ 
https://issues.apache.org/jira/browse/FLINK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658086#comment-16658086
 ] 

ASF GitHub Bot commented on FLINK-10251:
----------------------------------------

yanghua commented on issue #6876: [FLINK-10251] Handle oversized response 
messages in AkkaRpcActor
URL: https://github.com/apache/flink/pull/6876#issuecomment-431640196
 
 
   hi @tillrohrmann There is a problem about sending serialized data. For 
example, `testNoSlotSharingAndBlockingResultReceiver` will trigger 
`allocateSlot` rpc call, the result type is `SingleLogicalSlot` which has a 
field `private final CompletableFuture<Void> releaseFuture`. The field caused 
serialization error : 
   
   ```
   Caused by: org.apache.flink.runtime.rpc.akka.exceptions.AkkaRpcException: 
Failed to serialize the result for RPC call : allocateSlot.
        at 
org.apache.flink.runtime.rpc.akka.AkkaRpcActor.serializeResultAndVerifySize(AkkaRpcActor.java:335)
        at 
org.apache.flink.runtime.rpc.akka.AkkaRpcActor.lambda$handleRpcInvocation$1(AkkaRpcActor.java:280)
        ... 33 more
   Caused by: java.io.NotSerializableException: 
java.util.concurrent.CompletableFuture
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Handle oversized response messages in AkkaRpcActor
> --------------------------------------------------
>
>                 Key: FLINK-10251
>                 URL: https://issues.apache.org/jira/browse/FLINK-10251
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.3, 1.6.0, 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.6, 1.6.3, 1.7.0
>
>
> The {{AkkaRpcActor}} should check whether an RPC response which is sent to a 
> remote sender does not exceed the maximum framesize of the underlying 
> {{ActorSystem}}. If this is the case we should fail fast instead. We can 
> achieve this by serializing the response and sending the serialized byte 
> array.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to