[
https://issues.apache.org/jira/browse/FLINK-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658611#comment-16658611
]
ASF GitHub Bot commented on FLINK-10606:
----------------------------------------
zhijiangW opened a new pull request #6891: [FLINK-10606][network][test]
Construct NetworkEnvironment simple for tests
URL: https://github.com/apache/flink/pull/6891
## What is the purpose of the change
*Implement a simple constructor for `NetworkEnvironment`, which can be
widely used for existing tests to remove duplicate codes.*
## Brief change log
- *Define a new simple constructor for `NetworkEnvironment`*
- *Modify the existing tests based on new constructor*
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Construct NetworkEnvironment simple for tests
> ---------------------------------------------
>
> Key: FLINK-10606
> URL: https://issues.apache.org/jira/browse/FLINK-10606
> Project: Flink
> Issue Type: Test
> Components: Network, Tests
> Affects Versions: 1.6.1, 1.7.0
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
>
> Currently, five tests would create {{NetworkEnvironment}} in different places
> and the most of parameters are common in constructing it.
> We can provide a simple way for constructing the {{NetworkEnvironment}} with
> less parameters to deduplicate the common codes, which can bring benefits for
> future new tests.
> We can define a static nested {{NetworkEnvironmentBuilder}} inside the
> {{NetworkEnvironment or a simple constructor directly as the option.}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
