[
https://issues.apache.org/jira/browse/FLINK-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658744#comment-16658744
]
zhijiang edited comment on FLINK-10606 at 10/22/18 8:41 AM:
------------------------------------------------------------
[~pnowojski], this is the issue from the review of
[pr6809|https://github.com/apache/flink/pull/6809].
was (Author: zjwang):
[~pnowojski], this is the issue from the review ofÂ
[[pr6809|https://github.com/apache/flink/pull/6809]|https://github.com/apache/flink/pull/6809].
> Construct NetworkEnvironment simple for tests
> ---------------------------------------------
>
> Key: FLINK-10606
> URL: https://issues.apache.org/jira/browse/FLINK-10606
> Project: Flink
> Issue Type: Test
> Components: Network, Tests
> Affects Versions: 1.6.1, 1.7.0
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
>
> Currently, five tests would create {{NetworkEnvironment}} in different places
> and the most of parameters are common in constructing it.
> We can provide a simple way for constructing the {{NetworkEnvironment}} with
> less parameters to deduplicate the common codes, which can bring benefits for
> future new tests.
> We can define a static nested {{NetworkEnvironmentBuilder}} inside the
> {{NetworkEnvironment or a simple constructor directly as the option.}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
