pnowojski commented on a change in pull request #6838: 
[FLINK-9878][network][ssl] add more low-level ssl options
URL: https://github.com/apache/flink/pull/6838#discussion_r226293240
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/SSLHandlerFactory.java
 ##########
 @@ -36,29 +38,66 @@
 
        private final boolean clientMode;
 
-       final boolean clientAuthentication;
+       private final boolean clientAuthentication;
+
+       private final int handshakeTimeoutMs;
+
+       private final int closeNotifyFlushTimeoutMs;
 
-       public SSLEngineFactory(
+       /**
+        * Create a new SSLEngine factory.
 
 Review comment:
   nit: comment is outdated (`SSLEngine`).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to