[
https://issues.apache.org/jira/browse/FLINK-10570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659287#comment-16659287
]
ASF GitHub Bot commented on FLINK-10570:
----------------------------------------
dawidwys opened a new pull request #6896: [FLINK-10570] Fixed clearing shared
buffer nodes when using After match skip strategy
URL: https://github.com/apache/flink/pull/6896
## What is the purpose of the change
This PR fixes releasing nodes for matches when after match skip strategy is
applied.
## Verifying this change
This change added tests and can be verified as follows:
*
`org.apache.flink.cep.nfa.AfterMatchSkipITCase#testSharedBufferIsProperlyCleared`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> State grows unbounded when "within" constraint not applied
> ----------------------------------------------------------
>
> Key: FLINK-10570
> URL: https://issues.apache.org/jira/browse/FLINK-10570
> Project: Flink
> Issue Type: Bug
> Components: CEP
> Affects Versions: 1.6.1
> Reporter: Thomas Wozniakowski
> Assignee: Dawid Wysakowicz
> Priority: Major
> Labels: pull-request-available
>
> We have been running some failure monitoring using the CEP library. Simple
> stuff that should probably have been implemented with a window, rather than
> CEP, but we had already set the project up to use CEP elsewhere and it was
> trivial to add this.
> We ran the following pattern (on 1.4.2):
> {code:java}
> begin(PURCHASE_SEQUENCE, AfterMatchSkipStrategy.skipPastLastEvent())
> .subtype(PurchaseEvent.class)
> .times(100)
> {code}
> and then flat selected the responses if the failure ratio was over a certain
> threshold.
> With 1.6.1, the state size of the CEP operator for this pattern grows
> unbounded, and eventually destroys the job with an OOM exception. We have
> many CEP operators in this job but all the rest use a "within" call.
> In 1.4.2, it seems events would be discarded once they were no longer in the
> 100 most recent, now it seems they are held onto indefinitely.
> We have a workaround (we're just going to add a "within" call to force the
> CEP operator to discard old events), but it would be useful if we could have
> the old behaviour back.
> Please let me know if I can provide any more information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
